xuyangzhong commented on code in PR #27167:
URL: https://github.com/apache/flink/pull/27167#discussion_r2472588954
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/DeltaJoinTest.scala:
##########
@@ -376,6 +376,32 @@ class DeltaJoinTest extends TableTestBase {
ExplainDetail.PLAN_ADVICE)
}
+ @Test
+ def testExplainPlanAdviceWithLookupOptions(): Unit = {
Review Comment:
Nit what about renaming it to `testLookupTableWithCache`?
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/DeltaJoinTest.scala:
##########
@@ -376,6 +376,32 @@ class DeltaJoinTest extends TableTestBase {
ExplainDetail.PLAN_ADVICE)
}
+ @Test
+ def testExplainPlanAdviceWithLookupOptions(): Unit = {
+ val lookupOptions = new JHashMap[String, String]()
+ lookupOptions.put("lookup.cache", "partial")
+ lookupOptions.put("lookup.partial-cache.max-rows", "1000")
+ addTable(
Review Comment:
Nit if you pull the latest master, you can simplify this part by
```
replaceTable("src1", "src1", lookupOptions)
util.verifyExplainInsert(
"insert into snk select * from src1 join src2 " +
"on src1.a1 = src2.b1 " +
"and src1.a2 = src2.b2",
ExplainDetail.PLAN_ADVICE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
