SteveStevenpoor commented on code in PR #27167:
URL: https://github.com/apache/flink/pull/27167#discussion_r2483283430
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/DeltaJoinTest.scala:
##########
@@ -624,6 +624,21 @@ class DeltaJoinTest extends TableTestBase {
ExplainDetail.PLAN_ADVICE)
}
+ @Test
+ def testLookupTableWithCache(): Unit = {
Review Comment:
> Is there an end to end test we can add to drive this code outside of
explain? If this issue is explain only ,then we should mention the situations
that the user can hit this in the Jira or PR text - so people can find it
easier.
This issue isn’t explain-only, but I don’t think we can add an end-to-end
test right now since DeltaJoin only works with Fluss. Given that this fix is
just a two-word typo change, I’d suggest merging it as-is and creating a
separate ticket to enable an end-to-end test for DeltaJoin with the lookup
cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
