xuyangzhong commented on code in PR #27117:
URL: https://github.com/apache/flink/pull/27117#discussion_r2480226675
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##########
@@ -108,16 +116,40 @@ public List<String> getExpectedAfterRestoreAsStrings() {
}
public List<String> getExpectedAsStrings() {
- final List<String> data = new
ArrayList<>(getExpectedBeforeRestoreAsStrings());
- data.addAll(getExpectedAfterRestoreAsStrings());
- return data;
+ if (hasStringsSet() || deduplicatedFieldIndices == null) {
Review Comment:
It is possible, for example, when there is no expected sink data, but the
sink has a primary key (which will later use the primary key replaced by
`deduplicatedFieldIndices`).
Let me add this situation in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
