xuyangzhong commented on code in PR #27117:
URL: https://github.com/apache/flink/pull/27117#discussion_r2480285149


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##########
@@ -195,6 +195,10 @@ public final class TestValuesTableFactory
     private static final AtomicInteger idCounter = new AtomicInteger(0);
     private static final Map<String, Collection<Row>> registeredData = new 
HashMap<>();
     private static final Map<String, Collection<RowData>> registeredRowData = 
new HashMap<>();
+    // The difference between registeredDataForFullStage and `registeredData` 
is that
+    // `registeredData` is used for data delivered from the source to 
downstream, while the rows in
+    // `registeredDataForFullStage` will not be sent to downstream and are 
only used for lookup.
+    private static final Map<String, Collection<Row>> 
registeredDataForFullStage = new HashMap<>();

Review Comment:
   I have renamed it to `registeredConsumedData`.
   
   Different with `registeredRowData`, the `registeredConsumedData` will not be 
re-consumed by the source to be sent to downstream operators.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to