twalthr commented on code in PR #27017:
URL: https://github.com/apache/flink/pull/27017#discussion_r2486604873
##########
flink-core/src/test/java/org/apache/flink/types/variant/BinaryVariantInternalBuilderTest.java:
##########
@@ -116,4 +119,12 @@ void testParseJsonObject() throws IOException {
assertThat(variant.getField("k1").getByte()).isEqualTo((byte) 2);
assertThat(variant.getField("k2").getDecimal()).isEqualTo(BigDecimal.valueOf(1.5));
}
+
+ @Test
+ void testAppendFloat() {
+ BinaryVariantInternalBuilder builder = new
BinaryVariantInternalBuilder(false);
+ ArrayList<Float> floatList = new ArrayList<>(Collections.nCopies(25,
4.2f));
+
+ assertThatCode(() ->
floatList.forEach(builder::appendFloat)).doesNotThrowAnyException();
Review Comment:
But why did the `testScalarVariant` not catch the the bug then? Ideally, we
should have tests that write and read to have a symmetric serialization and
deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
