JinkunLiu commented on code in PR #27017:
URL: https://github.com/apache/flink/pull/27017#discussion_r2432916871
##########
flink-core/src/test/java/org/apache/flink/types/variant/BinaryVariantInternalBuilderTest.java:
##########
@@ -116,4 +119,12 @@ void testParseJsonObject() throws IOException {
assertThat(variant.getField("k1").getByte()).isEqualTo((byte) 2);
assertThat(variant.getField("k2").getDecimal()).isEqualTo(BigDecimal.valueOf(1.5));
}
+
+ @Test
+ void testAppendFloat() {
+ BinaryVariantInternalBuilder builder = new
BinaryVariantInternalBuilder(false);
+ ArrayList<Float> floatList = new ArrayList<>(Collections.nCopies(25,
4.2f));
+
+ assertThatCode(() ->
floatList.forEach(builder::appendFloat)).doesNotThrowAnyException();
Review Comment:
Certainly, I'd be happy to. However, I noticed that the appendFloat method
is already covered by the
`org.apache.flink.types.variant.BinaryVariantTest#testScalarVariant` method. Do
I still need to add an additional test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
