davidradl commented on code in PR #27210:
URL: https://github.com/apache/flink/pull/27210#discussion_r2509741791
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/LogicalUnnestRule.java:
##########
@@ -161,6 +167,35 @@ private RelNode getRel(RelNode rel) {
return rel;
}
+ /**
+ * If unnesting type is {@code NOT NULL} however at the same time {@code
LEFT JOIN} makes it
+ * nullable, this method adjust nullability by inserting extra {@code
CAST}.
+ */
+ private LogicalProject
getLogicalProjectWithAdjustNullability(LogicalProject logicalProject) {
Review Comment:
nit: getLogicalProjectWithAdjustNullability ->
getLogicalProjectWithAdjustedNullability
I think would be a more readbable name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
