twalthr commented on code in PR #27210:
URL: https://github.com/apache/flink/pull/27210#discussion_r2510411095
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/common/UnnestTestBase.scala:
##########
@@ -32,6 +32,19 @@ abstract class UnnestTestBase(withExecPlan: Boolean) extends
TableTestBase {
protected def getTableTestUtil: TableTestUtil
+ @BeforeEach
+ def setupBeforeEach(): Unit = {
+ util.addTable("""
+ |CREATE TABLE reproduce_unnest (
Review Comment:
```suggestion
|CREATE TABLE nested_not_null (
```
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/common/UnnestTestBase.scala:
##########
@@ -232,6 +245,42 @@ abstract class UnnestTestBase(withExecPlan: Boolean)
extends TableTestBase {
|""".stripMargin)
}
+ @Test
+ def testUnnestNullMismatchLeftJoin(): Unit = {
Review Comment:
nit: all tests here are for Unnest. Method names can be shortened
```suggestion
def testNullMismatchLeftJoin(): Unit = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
