davidradl commented on code in PR #27236:
URL: https://github.com/apache/flink/pull/27236#discussion_r2523403470
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -116,18 +116,20 @@ public static String buildShowCreateTableRow(
public static String buildShowCreateMaterializedTableRow(
ResolvedCatalogMaterializedTable table,
ObjectIdentifier tableIdentifier,
- boolean isTemporary) {
+ boolean isTemporary,
+ SqlFactory sqlFactory) {
validateTableKind(table, tableIdentifier,
TableKind.MATERIALIZED_TABLE);
- Optional<String> primaryKeys = extractFormattedPrimaryKey(table,
PRINT_INDENT);
StringBuilder sb =
new StringBuilder()
.append(
buildCreateFormattedPrefix(
- "MATERIALIZED TABLE",
- isTemporary,
- tableIdentifier,
- primaryKeys.isPresent()));
- primaryKeys.ifPresent(s -> sb.append(s).append("\n)\n"));
+ "MATERIALIZED TABLE", isTemporary,
tableIdentifier, true));
+ sb.append(extractFormattedColumns(table, PRINT_INDENT));
+ extractFormattedWatermarkSpecs(table, PRINT_INDENT, sqlFactory)
Review Comment:
sounds good - can we remove it from this method prototype as well. Or do we
think we might introduce a temporary materialized table at some stage in the
future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
