davidradl commented on code in PR #27236:
URL: https://github.com/apache/flink/pull/27236#discussion_r2523111579
##########
docs/content/docs/dev/table/sql/show.md:
##########
@@ -986,6 +988,29 @@ SHOW CREATE VIEW [catalog_name.][db_name.]view_name
Show create view statement for specified view.
+## SHOW MATERIALIZED VIEWS
+
+```sql
+SHOW MATERIALIZED TABLES [ ( FROM | IN ) [catalog_name.]database_name ] [
[NOT] LIKE <sql_like_pattern> ]
+```
+
+Show all materialized tables for an optionally specified database. If no
database is specified then the materialized tables are returned from the
current database. Additionally, the output of this statement may be filtered by
an optional matching pattern.
+
+**LIKE**
+Show all materialized tables with given view name and optional `LIKE` clause,
whose name is whether similar to the `<sql_like_pattern>`.
+
+The syntax of sql pattern in `LIKE` clause is the same as that of `MySQL`
dialect.
+* `%` matches any number of characters, even zero characters, `\%` matches one
`%` character.
+* `_` matches exactly one character, `\_` matches one `_` character.
+
+## SHOW CREATE MATERIALIZED TABLE
+
+```sql
+SHOW CREATE MATERIALIZED TABLE [catalog_name.][db_name.]materialized_table_name
Review Comment:
It looks like the code has temporary versions of the CREATE, we should
document the temporary shows
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -116,18 +116,20 @@ public static String buildShowCreateTableRow(
public static String buildShowCreateMaterializedTableRow(
ResolvedCatalogMaterializedTable table,
ObjectIdentifier tableIdentifier,
- boolean isTemporary) {
+ boolean isTemporary,
+ SqlFactory sqlFactory) {
validateTableKind(table, tableIdentifier,
TableKind.MATERIALIZED_TABLE);
- Optional<String> primaryKeys = extractFormattedPrimaryKey(table,
PRINT_INDENT);
StringBuilder sb =
new StringBuilder()
.append(
buildCreateFormattedPrefix(
- "MATERIALIZED TABLE",
- isTemporary,
- tableIdentifier,
- primaryKeys.isPresent()));
- primaryKeys.ifPresent(s -> sb.append(s).append("\n)\n"));
+ "MATERIALIZED TABLE", isTemporary,
tableIdentifier, true));
+ sb.append(extractFormattedColumns(table, PRINT_INDENT));
+ extractFormattedWatermarkSpecs(table, PRINT_INDENT, sqlFactory)
Review Comment:
can we print out something for isTemporary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
