AHeise commented on code in PR #27254:
URL: https://github.com/apache/flink/pull/27254#discussion_r2543451030
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointRescaleITCase.java:
##########
@@ -619,8 +619,10 @@ public void shouldRescaleUnalignedCheckpoint() throws
Exception {
.setExpectedFailures(1)
.setSourceSleepMs(sourceSleepMs);
prescaleSettings.setGenerateCheckpoint(true);
- final File checkpointDir = super.execute(prescaleSettings);
-
+ final String checkpointDir = super.execute(prescaleSettings);
+ assertNotNull(
+ "First job must generate a checkpoint for rescale test to be
valid.",
+ checkpointDir);
Review Comment:
Please use assertj (`assertThat(checkpointDir).as("First job must generate a
checkpoint for rescale test to be valid.").isNotNull`)
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java:
##########
@@ -198,13 +199,17 @@ protected File execute(UnalignedSettings settings) throws
Exception {
if (settings.generateCheckpoint) {
return CommonTestUtils.getLatestCompletedCheckpointPath(
jobID, miniCluster.getMiniCluster())
- .map(File::new)
.orElseThrow(() -> new AssertionError("Could not
generate checkpoint"));
Review Comment:
Should we `Fail.fail("Expected exception")` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
