1996fanrui commented on code in PR #27254:
URL: https://github.com/apache/flink/pull/27254#discussion_r2589153310


##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java:
##########
@@ -754,6 +772,8 @@ public void configure(StreamExecutionEnvironment env) {
             env.getCheckpointConfig()
                     
.setTolerableCheckpointFailureNumber(tolerableCheckpointFailures);
             env.setParallelism(parallelism);
+            RestartStrategyUtils.configureFixedDelayRestartStrategy(
+                    env, generateCheckpoint ? expectedFailures / 2 : 
expectedFailures, 100L);

Review Comment:
   It reverts the change in 
https://github.com/apache/flink/pull/27119/files#diff-ace775e80e66d4f4001bdaea6bcbaae1975bd5e9a5497532d8d7152e4090069aL752
   
   The original intention is :
   
   - `generateCheckpoint` controls the operational phase: true is for the job 
before rescaling, and false is for the new job after rescaling
   - The value `expectedFailures / 2` acts as the failure threshold for the 
first job. This setup ensures that the first job fails after half of the 
expected exceptions are met, allowing the second job to automatically recover 
from the generated checkpoint and continue consumption.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to