snuyanzin commented on code in PR #27256:
URL: https://github.com/apache/flink/pull/27256#discussion_r2546109981
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -174,23 +175,23 @@ void testUseCatalog() {
@ParameterizedTest
@CsvSource({"true,true", "true,false", "false,true", "false,false"})
void testCreateCatalog(boolean ifNotExists, boolean comment) {
- String ifNotExistsClause = ifNotExists ? "if not exists " : "";
- String commentClause = comment ? "\ncomment 'HELLO' " : " ";
+ final String ifNotExistsClause = ifNotExists ? "if not exists " : "";
+ final String commentClause = comment ? "\ncomment 'HELLO'" : "";
sql("create catalog "
+ ifNotExistsClause
+ "c1"
+ commentClause
- + " WITH (\n"
+ + "\nWITH (\n"
Review Comment:
It also aligns behavior for `WITH` (always put on a new line)
However as a note: it doesn't impact `SHOW CREATE` output since for `SHOW
CREATE` there is separate logic in `ShowCreateUtil`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
