davidradl commented on code in PR #27256:
URL: https://github.com/apache/flink/pull/27256#discussion_r2549206852
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterMaterializedTableRefresh.java:
##########
@@ -43,12 +43,12 @@ public SqlAlterMaterializedTableRefresh(
@Override
public List<SqlNode> getOperandList() {
- return ImmutableNullableList.of(getTableName(), partitionSpec);
+ return ImmutableNullableList.of(getName(), partitionSpec);
Review Comment:
I am curious about these changes to getName(). Seeing a table operation
refer to getTableName() is very readable and explicit, and I assume works. If
this was in a superclass that referred to things other than table I could see a
motivation for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
