snuyanzin commented on code in PR #27256:
URL: https://github.com/apache/flink/pull/27256#discussion_r2549685530
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java:
##########
@@ -579,22 +578,18 @@ private Operation convertCreateDatabase(SqlCreateDatabase
sqlCreateDatabase) {
String databaseName =
(fullDatabaseName.length == 1) ? fullDatabaseName[0] :
fullDatabaseName[1];
boolean ignoreIfExists = sqlCreateDatabase.isIfNotExists();
- String databaseComment =
- sqlCreateDatabase
- .getComment()
- .map(comment ->
comment.getValueAs(NlsString.class).getValue())
- .orElse(null);
+ String databaseComment =
OperationConverterUtils.getComment(sqlCreateDatabase.getComment());
// set with properties
final Map<String, String> properties =
-
OperationConverterUtils.getProperties(sqlCreateDatabase.getPropertyList());
+
OperationConverterUtils.getProperties(sqlCreateDatabase.getProperties());
Review Comment:
makes sense, added same for List<String>
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java:
##########
@@ -579,22 +578,18 @@ private Operation convertCreateDatabase(SqlCreateDatabase
sqlCreateDatabase) {
String databaseName =
(fullDatabaseName.length == 1) ? fullDatabaseName[0] :
fullDatabaseName[1];
boolean ignoreIfExists = sqlCreateDatabase.isIfNotExists();
- String databaseComment =
- sqlCreateDatabase
- .getComment()
- .map(comment ->
comment.getValueAs(NlsString.class).getValue())
- .orElse(null);
+ String databaseComment =
OperationConverterUtils.getComment(sqlCreateDatabase.getComment());
// set with properties
final Map<String, String> properties =
-
OperationConverterUtils.getProperties(sqlCreateDatabase.getPropertyList());
+
OperationConverterUtils.getProperties(sqlCreateDatabase.getProperties());
Review Comment:
makes sense, added same also for `List<String>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
