ferenc-csaky commented on code in PR #161: URL: https://github.com/apache/flink-connector-jdbc/pull/161#discussion_r2550192119
########## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/RowDataResultExtractor.java: ########## Review Comment: I see, I ignored the fact the current `extractor` pkg is under the `datastream` pkg, yep putting it there would be wrong. I still think though the cleanest packaging would be grouping those extractors together. How about moving the extractor package to `org.apache.flink.connector.jdbc.core.database.extractor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
