eskabetxe commented on code in PR #161: URL: https://github.com/apache/flink-connector-jdbc/pull/161#discussion_r2550498312
########## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/extractor/RowDataResultExtractor.java: ########## Review Comment: > I'd rather put this class into the `extractor` package, next to its interface and `RowExtractor`. Based on the current grouping IMO it makes more sense. I would say that this makes more sense to me, as tableApi is using datastreamAPI and ResultExtractor is created for datastream use case, and I can see this new implementation used on datastream use cases also (reading from jdbc and sending to paimon/iceberg as example) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
