snuyanzin commented on code in PR #27302:
URL: https://github.com/apache/flink/pull/27302#discussion_r2584654409
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlMaterializedTableNodeToOperationConverterTest.java:
##########
@@ -140,36 +185,19 @@ void testCreateMaterializedTable() {
CreateMaterializedTableOperation op =
(CreateMaterializedTableOperation) operation;
ResolvedCatalogMaterializedTable materializedTable =
op.getCatalogMaterializedTable();
- Map<String, String> options = Map.of("connector", "filesystem",
"format", "json");
- CatalogMaterializedTable expected =
- CatalogMaterializedTable.newBuilder()
- .schema(
- Schema.newBuilder()
- .column("a",
DataTypes.BIGINT().notNull())
- .column("b",
DataTypes.VARCHAR(Integer.MAX_VALUE))
- .column("c", DataTypes.INT())
- .column("d",
DataTypes.VARCHAR(Integer.MAX_VALUE))
- .primaryKeyNamed("ct1",
Collections.singletonList("a"))
- .build())
- .comment("materialized table comment")
- .options(options)
- .partitionKeys(Arrays.asList("a", "d"))
- .freshness(IntervalFreshness.ofSecond("30"))
-
.logicalRefreshMode(CatalogMaterializedTable.LogicalRefreshMode.FULL)
- .refreshMode(RefreshMode.FULL)
-
.refreshStatus(CatalogMaterializedTable.RefreshStatus.INITIALIZING)
- .originalQuery("SELECT *\nFROM `t1`")
- .expandedQuery(
- "SELECT `t1`.`a`, `t1`.`b`, `t1`.`c`,
`t1`.`d`\n"
- + "FROM `builtin`.`default`.`t1` AS
`t1`")
- .build();
-
final IntervalFreshness resolvedFreshness =
materializedTable.getDefinitionFreshness();
assertThat(resolvedFreshness).isEqualTo(IntervalFreshness.ofSecond("30"));
final RefreshMode resolvedRefreshMode =
materializedTable.getRefreshMode();
assertThat(resolvedRefreshMode).isSameAs(RefreshMode.FULL);
+ final CatalogMaterializedTable expected =
+ getDefaultMaterializedTablebuilder()
+ .freshness(IntervalFreshness.ofSecond("30"))
+
.logicalRefreshMode(CatalogMaterializedTable.LogicalRefreshMode.FULL)
+ .refreshMode(RefreshMode.FULL)
+
.refreshStatus(CatalogMaterializedTable.RefreshStatus.INITIALIZING)
Review Comment:
Added extra check for this to checkstyle and fixed all the findings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
