snuyanzin commented on code in PR #27302:
URL: https://github.com/apache/flink/pull/27302#discussion_r2585323812
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala:
##########
@@ -68,9 +68,9 @@ class TableEnvironmentTest {
@Test
def testScanNonExistTable(): Unit = {
- assertThatThrownBy(() => tableEnv.from("MyTable"))
- .hasMessageContaining("Table `MyTable` was not found")
- .isInstanceOf[ValidationException]
+ assertThatExceptionOfType(classOf[ValidationException])
+ .isThrownBy(() => tableEnv.from("MyTable"))
+ .withMessageContaining("Table `MyTable` was not found")
Review Comment:
Since this test class was touched (while addressing feedback for message
content).
mainly switch to `assertThatExceptionOfType`, since `assertThatThrownBy` in
scala and IntellijIdea is a huge pain ...
also moved to assertj some trivial things, however not everything since
there are a lot here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
