ferenc-csaky commented on code in PR #219:
URL:
https://github.com/apache/flink-connector-aws/pull/219#discussion_r2607912953
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplitState.java:
##########
@@ -70,4 +72,12 @@ public String getNextShardIterator() {
public void setNextShardIterator(String nextShardIterator) {
this.nextShardIterator = nextShardIterator;
}
+
+ public boolean getShardEndReached() {
Review Comment:
This should be `isShardEndReached()`
##########
flink-connector-aws/flink-connector-dynamodb/pom.xml:
##########
@@ -31,6 +31,18 @@ under the License.
<artifactId>flink-connector-dynamodb</artifactId>
<name>Flink : Connectors : AWS : Amazon DynamoDB</name>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>9</source>
+ <target>9</target>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
Review Comment:
This is only required for intellij, but if you activate the `java11-target`
profile, it should enable using JDK11 features. But this part should be deleted
for sure. If that fails the CI build, then we can revert using `List.of`.
I want to bump this in the connector parent, cause now Flink 2.x also
dropped JDK8 so it not makes sense that connector code is limited to that by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
