gguptp commented on code in PR #219:
URL:
https://github.com/apache/flink-connector-aws/pull/219#discussion_r2601200988
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplit.java:
##########
@@ -50,12 +56,31 @@ public DynamoDbStreamsShardSplit(
this(streamArn, shardId, startingPosition, parentShardId, false);
}
+ public DynamoDbStreamsShardSplit(
+ String streamArn,
+ String shardId,
+ StartingPosition startingPosition,
+ String parentShardId,
+ List<Shard> childSplits) {
+ this(streamArn, shardId, startingPosition, parentShardId, false,
childSplits);
+ }
+
public DynamoDbStreamsShardSplit(
String streamArn,
String shardId,
StartingPosition startingPosition,
String parentShardId,
boolean isFinished) {
+ this(streamArn, shardId, startingPosition, parentShardId, isFinished,
new ArrayList<>());
Review Comment:
since the connector has to be compatible with java8, i dont think list.of
will work here, hence keeping new ArrayList<>();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
