gustavodemorais commented on code in PR #27352:
URL: https://github.com/apache/flink/pull/27352#discussion_r2634938781
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNode.java:
##########
@@ -65,12 +65,26 @@ public interface ExecNode<T> extends ExecNodeTranslator<T>,
FusionCodegenExecNod
@JsonProperty(value = FIELD_NAME_ID, index = 0)
int getId();
+ /**
+ * The node's type as contained in {@link CompiledPlan} (e.g.
"stream-exec-table-source-scan_2"
+ * consisting of name and version).
+ *
+ * <p>A new type including its version can be added by declaring a {@link
ExecNodeMetadata}
+ * annotation.
+ *
+ * @see ExecNodeContext#getTypeAsString()
+ */
+ @JsonIgnore
+ String getTypeAsString();
Review Comment:
nit: The first thing I thought is that this would return the output type so
I'd have gone with `getNodeTypeAsString`. But I see why the other methods don't
follow this naming pattern and why `getTypeAsString` matches them
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNode.java:
##########
@@ -65,12 +65,26 @@ public interface ExecNode<T> extends ExecNodeTranslator<T>,
FusionCodegenExecNod
@JsonProperty(value = FIELD_NAME_ID, index = 0)
int getId();
+ /**
+ * The node's type as contained in {@link CompiledPlan} (e.g.
"stream-exec-table-source-scan_2"
+ * consisting of name and version).
+ *
+ * <p>A new type including its version can be added by declaring a {@link
ExecNodeMetadata}
+ * annotation.
+ *
+ * @see ExecNodeContext#getTypeAsString()
+ */
+ @JsonIgnore
+ String getTypeAsString();
Review Comment:
nit: The first thing I thought is that this would return the output type so
I'd have gone with `getNodeTypeAsString`. But I see why the other methods don't
follow this naming pattern and why `getTypeAsString` matches them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
