davidradl commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/48#discussion_r2661710809
##########
pom.xml:
##########
@@ -60,9 +60,8 @@ under the License.
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <target.java.version>1.8</target.java.version>
- <maven.compiler.source>${target.java.version}</maven.compiler.source>
- <maven.compiler.target>${target.java.version}</maven.compiler.target>
+ <maven.compiler.source>17</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
@tomncooper I think it should be the same as the [Flink 2.2
pom](https://github.com/apache/flink/blob/932aa4306efadc8107a33da5efa184a7c71dd14e/pom.xml#L134)
source should be 11, target 17. I assume the thinking is that we want to
support Java 17, but there may be java 11 code in the Flink code base. I do not
know how the connectors might be broken if we set java 17 as the source; but I
suspect to be safe we should just match the flink pom.
@ferenc-csaky any insight as to why we must have source as 11 for the
connectors, if we can leave the source as 17 that would be beneficial, so
people do not introduce new java 11 specific source code in new connectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
