davidradl commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/48#discussion_r2661898219
##########
pom.xml:
##########
@@ -60,9 +60,8 @@ under the License.
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <target.java.version>1.8</target.java.version>
- <maven.compiler.source>${target.java.version}</maven.compiler.source>
- <maven.compiler.target>${target.java.version}</maven.compiler.target>
+ <maven.compiler.source>17</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
@ferenc-csaky thanks for your update. This is my understanding now:
I assume that to support JDK 11 a Maven build option to supply
`maven.compiler.target` as 11 would be needed. In order to allow this to work
we need <maven.compiler.source>11</maven.compiler.source>. The
`<maven.compiler.target>17</maven.compiler.target>` is just what we target by
default.
So for example - this will allow the [Kafka connector CI
](https://github.com/apache/flink-connector-kafka/blob/a90e8f48a09703eeb87dd2e3de7985f678762674/.github/workflows/push_pr.yml#L32)
to continue to build against jdk 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
