davidradl commented on code in PR #12:
URL:
https://github.com/apache/flink-connector-http/pull/12#discussion_r2682230649
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/JavaNetHttpPollingClient.java:
##########
@@ -326,22 +326,42 @@ private Collection<RowData> deserialize(String
responseBody) throws IOException
}
}
- private List<RowData> deserializeSingleValue(byte[] rawBytes) throws
IOException {
- return Optional.ofNullable(responseBodyDecoder.deserialize(rawBytes))
- .map(Collections::singletonList)
- .orElse(Collections.emptyList());
+ @VisibleForTesting
+ List<RowData> deserializeSingleValue(byte[] rawBytes) throws IOException {
+ List<RowData> result = new ArrayList<>();
+ responseBodyDecoder.deserialize(rawBytes, new ListCollector(result));
+ return Collections.unmodifiableList(result);
}
- private List<RowData> deserializeArray(byte[] rawBytes) throws IOException
{
+ private static class ListCollector implements
org.apache.flink.util.Collector<RowData> {
Review Comment:
@ferenc-csaky My mistake - I meant this to be left unchanged - let me raise
another PR to address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
