[
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825588#comment-15825588
]
ASF GitHub Bot commented on FLINK-5256:
---------------------------------------
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96356194
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -144,21 +150,46 @@ class DataSetSingleRowJoin(
val condition = codeGenerator.generateExpression(joinCondition)
- val joinMethodBody = s"""
- |${condition.code}
- |if (${condition.resultTerm}) {
- | ${conversion.code}
- |
${codeGenerator.collectorTerm}.collect(${conversion.resultTerm});
- |}
- |""".stripMargin
+ val joinMethodBody =
+ if (joinType == JoinRelType.INNER) {
+ s"""
+ |${condition.code}
+ |if (${condition.resultTerm}) {
+ | ${conversion.code}
+ |
${codeGenerator.collectorTerm}.collect(${conversion.resultTerm});
+ |}
+ |""".stripMargin
+ } else {
+ val singleNode =
+ if (leftIsSingle) {
+ leftNode
+ }
+ else {
+ rightNode
+ }
+ val notSuitedToCondition = singleNode
+ .getRowType
+ .getFieldList
+ .map(field => getRowType.getFieldNames.indexOf(field.getName))
+ .map(i => s"${conversion.resultTerm}.setField($i,null);")
+
+ s"""
+ |${condition.code}
+ |${conversion.code}
+ |if(!${condition.resultTerm}){
+ |${notSuitedToCondition.mkString("\n")}
--- End diff --
I think this part is excessive, because in result code we get:
```java
//{condition.code}
boolean isNull$55 = isNull$45 || isNull$50;
boolean result$54;
if (isNull$55) {
result$54 = false;
}
else {
result$54 = result$44 > result$49;
}
//{conversion.code}
if (isNull$45) {
out.setField(0, null);
}
else {
out.setField(0, result$44);
}
if (isNull$50) {
out.setField(1, null);
}
else {
out.setField(1, result$49);
}
//if(!${condition.resultTerm}){
{notSuitedToCondition.mkString("\n")}
if(!result$54){
out.setField(1,null);
}
```
As result we twice write to 1 field - rewrite value on null. I don't know
how do it better.
> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
> Key: FLINK-5256
> URL: https://issues.apache.org/jira/browse/FLINK-5256
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and
> right joins with single input. These cases can be handled if the
> {{DataSetSingleRowJoin}} is extended to support outer joins on the
> non-single-row input, i.e., left joins if the right side is single input and
> vice versa.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
