[ 
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769621#comment-15769621
 ] 

Anton Mushin commented on FLINK-5256:
-------------------------------------

Hi [~fhueske],
Thanks for your comments!
bq. I'm afraid, the PR does not correctly approach the problem and is actually 
introducing a bug.
I’m sorry about that.

About {{testSingleRowOuterJoin}} from your comment, I try execute it and get 
next exception:
{noformat}
java.lang.AssertionError: Different elements in arrays: expected 15 elements 
and received 9
 expected: [1,null, 2,null, 2,null, 3,null, 3,null, 3,null, 4,3, 4,3, 4,3, 4,3, 
5,3, 5,3, 5,3, 5,3, 5,3]
 received: [4,3, 4,3, 4,3, 4,3, 5,3, 5,3, 5,3, 5,3, 5,3] 
{noformat}
How you can see, all rows with null is missing, and I don't know cause. Could 
you give me a hit what I should look for that fix it?

> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary 
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and 
> right joins with single input. These cases can be handled if the  
> {{DataSetSingleRowJoin}} is extended to support outer joins on the 
> non-single-row input, i.e., left joins if the right side is single input and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to