twalthr commented on code in PR #27435:
URL: https://github.com/apache/flink/pull/27435#discussion_r2703849448
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/DiffRepository.java:
##########
@@ -435,7 +436,14 @@ public void assertEquals(String testCaseName, String tag,
String expected, Strin
// for largish snippets
String expected2Canonical =
expected2.replace(Util.LINE_SEPARATOR, "\n");
String actualCanonical = actual.replace(Util.LINE_SEPARATOR,
"\n");
- Assertions.assertEquals(expected2Canonical, actualCanonical,
tag);
+ assertThat(actualCanonical)
+ .withFailMessage(
+ () ->
+ "Expected: "
+ + expected2Canonical
+ + " but was: "
+ + actualCanonical)
+ .isEqualTo(expected2Canonical);
Review Comment:
feel free to use code comments for such cases, will help readers in the
future :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
