snuyanzin commented on code in PR #27433:
URL: https://github.com/apache/flink/pull/27433#discussion_r2704169921
##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java:
##########
@@ -220,6 +220,9 @@ void testCancelWhileFailing() throws Exception {
scheduler.handleGlobalFailure(new Exception("test"));
+ // Give time for the failure to be processed
+ Thread.sleep(10);
+
Review Comment:
We should not rely on timeouts in tests
this is is also mentioned in contribution guide
https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-timeouts-in-junit-tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
