davidradl commented on code in PR #27433:
URL: https://github.com/apache/flink/pull/27433#discussion_r2704892400


##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java:
##########
@@ -220,6 +220,9 @@ void testCancelWhileFailing() throws Exception {
 
             scheduler.handleGlobalFailure(new Exception("test"));
 
+            // Give time for the failure to be processed
+            Thread.sleep(10);
+

Review Comment:
   OK I was following the existing approach in the code. Also I see 
ExecutionGraphTestUtils.waitUntilJobStatus that is effectively a method doing 
the timeout. The comment says  ` // this is a poor implementation - we may want 
to improve it eventually`
   
   I will investigate to see if there is another way,   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to