davidradl commented on code in PR #27441:
URL: https://github.com/apache/flink/pull/27441#discussion_r2704757134
##########
docs/layouts/shortcodes/generated/checkpointing_configuration.html:
##########
@@ -122,6 +122,12 @@
<td>Duration</td>
<td>The minimal pause between checkpointing attempts. This setting
defines how soon thecheckpoint coordinator may trigger another checkpoint after
it becomes possible to triggeranother checkpoint with respect to the maximum
number of concurrent checkpoints(see <code
class="highlighter-rouge">execution.checkpointing.max-concurrent-checkpoints</code>).<br
/><br />If the maximum number of concurrent checkpoints is set to one, this
setting makes effectively sure that a minimum amount of time passes where no
checkpoint is in progress at all.</td>
</tr>
+ <tr>
+
<td><h5>execution.checkpointing.pause-checkpoints-if-tasks-not-running</h5></td>
+ <td style="word-wrap: break-word;">false</td>
+ <td>Boolean</td>
+ <td>When enabled, checkpoints will be paused as long as some tasks
are not running (and not finished), even if the job status is running. This
help to prevent an additional delay on job startup</td>
Review Comment:
I am struggling with these sentences.
- nit it would be simpler to say _if any tasks_ rather than _as long as some
tasks_
- What does it mean to say a task is not running, but has a status of
running? I think we need to talk about non blocking output, maybe more words
outside of the config definition to say how to recognise non blocking jobs - as
these seem to be the subset of jobs we are effecting here.
- nit: This help -> This helps
- the text says "prevent an additional delay on job startup". But the logic
does not seem startup specific? Can we get into any other non startup related
scenarios where this might be helpful
- Can we guide the user as to when they should consider using this option
and any downside to using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
