davidradl commented on code in PR #27441:
URL: https://github.com/apache/flink/pull/27441#discussion_r2704825685
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -2146,18 +2148,24 @@ private void restoreStateToCoordinators(
// job status listener that schedules / cancels periodic checkpoints
// ------------------------------------------------------------------------
- public JobStatusListener createActivatorDeactivator(boolean
allTasksOutputNonBlocking) {
+ public CheckpointCoordinatorDeActivator createActivatorDeactivator(
+ boolean allTasksOutputNonBlocking) {
synchronized (lock) {
if (shutdown) {
throw new IllegalArgumentException("Checkpoint coordinator is
shut down");
}
- if (jobStatusListener == null) {
- jobStatusListener =
- new CheckpointCoordinatorDeActivator(this,
allTasksOutputNonBlocking);
+ if (deActivator == null) {
+ if (pauseCheckpointsIfTasksNotRunning &&
allTasksOutputNonBlocking) {
+ deActivator = new
ExecutionTrackingCheckpointCoordinatorDeActivator(this);
Review Comment:
Maybe a comment to indicate why this if body results in a pause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
