snuyanzin commented on code in PR #27445: URL: https://github.com/apache/flink/pull/27445#discussion_r2707076081
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/WindowTVFWithOrderByITCase.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.runtime.stream.sql; + +import org.apache.flink.table.planner.runtime.utils.StreamingTestBase; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Integration tests for window TVFs (TUMBLE, HOP, SESSION, CUMULATE) combined with ORDER BY clauses + * in VIEW definitions. + * + * <p>These tests verify that views containing window table functions with ORDER BY can be created + * and queried successfully. This ensures proper SQL generation and parsing when views are expanded + * during query execution. + * + * <p>Test coverage includes: + * + * <ul> + * <li>TUMBLE window with ORDER BY + * <li>HOP window with ORDER BY + * <li>SESSION window with ORDER BY + * <li>CUMULATE window with ORDER BY + * </ul> + */ +class WindowTVFWithOrderByITCase extends StreamingTestBase { Review Comment: instead of creating a new test class can we reuse existing `CatalogViewITCase`? Do different windows change anything? It looks like window type is not participating in decision about adding `ORDER BY`, so no need to add all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
