llllssss94 commented on code in PR #27423:
URL: https://github.com/apache/flink/pull/27423#discussion_r2710578941
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCompletedCheckpointStorageLocation.java:
##########
@@ -71,6 +71,7 @@ public void disposeStorageLocation() throws IOException {
if (fs == null) {
fs = exclusiveCheckpointDir.getFileSystem();
}
- fs.delete(exclusiveCheckpointDir, false);
+ // Recursively delete the checkpoint directory and all its contents
+ fs.delete(exclusiveCheckpointDir, true);
Review Comment:
Thanks!
I thought about this. Even before this change, errors from the underlying
filesystem handler were already caught and logged, and those logs were
sufficient to debug the issue.
If we find that permission-related failures need special handling, we can
add a targeted catch for that specific error type. For now, I think the
existing logging is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
