rkhachatryan commented on code in PR #27440:
URL: https://github.com/apache/flink/pull/27440#discussion_r2724403181
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -1137,10 +1137,8 @@ public boolean hasSufficientResources() {
private JobAllocationsInformation
getJobAllocationsInformationFromGraphAndState(
@Nullable final ExecutionGraph previousExecutionGraph) {
- CompletedCheckpoint latestCompletedCheckpoint = null;
- if (jobGraph.isCheckpointingEnabled()) {
- latestCompletedCheckpoint =
completedCheckpointStore.getLatestCheckpoint();
- }
Review Comment:
@1996fanrui , @Izeren
After after minimizing the delay for automatic checkpoints,
`LocalRecoveryTest#testStateSizeIsConsideredForLocalRecoveryOnRestart` starts
failing because there's a race condition between a manual and automatic
checkpoints.
So I disabled automatic checkpoints in test and removed ` if
(jobGraph.isCheckpointingEnabled())` check (in prod code).
This should be fine - `completedCheckpointStore` should never be null.
Besides of test, I think checkpointing can be disabled before recovering the
job, and this branch should still be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
