eemario commented on code in PR #27464:
URL: https://github.com/apache/flink/pull/27464#discussion_r2730053319
##########
flink-runtime-web/web-dashboard/src/app/components/job-list/job-list.component.html:
##########
@@ -28,9 +28,11 @@
<thead>
<tr>
<th [nzSortFn]="sortJobNameFn" nzWidth="40%">Job Name</th>
- <th [nzSortFn]="sortStartTimeFn">Start Time</th>
+ <th [nzSortFn]="sortStartTimeFn" [nzSortOrder]="completed ? null :
'descend'">
Review Comment:
Thanks @davidradl, these are really inspiring. I'd like to explain why I've
opted to handle sorting on the frontend for now:
- Existing frontend capability: The UI already supports user-driven sorting
(e.g., clicking column headers to toggle sort order). Adding a default sort
order is a natural and lightweight extension of that logic. It also gives us
the flexibility to apply different default sorting strategies for completed vs.
running jobs without needing separate backend endpoints or complex query
parameters.
- Performance considerations: Based on production observations, it’s quite
rare for users to have more than a few hundred jobs at once. At that scale,
client-side sorting is still performant and acceptable. If we do encounter
scenarios with significantly larger job volumes that cause noticeable
slowdowns, we can revisit the approach and consider optimizations (e.g.,
server-side sorting, pagination, or lazy loading). For now, I think we can keep
things simple. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
