ferenc-csaky commented on code in PR #27469:
URL: https://github.com/apache/flink/pull/27469#discussion_r2736311303
##########
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java:
##########
@@ -93,11 +94,11 @@ class ClientTest {
private static final Logger LOG =
LoggerFactory.getLogger(ClientTest.class);
// Thread pool for client bootstrap (shared between tests)
- private NioEventLoopGroup nioGroup;
+ private MultiThreadIoEventLoopGroup nioGroup;
Review Comment:
Are there any meaningful difference between the old and new `LoopGroup` impl?
##########
flink-python/pom.xml:
##########
@@ -418,6 +418,15 @@ under the License.
<version>2.5.1</version>
<scope>runtime</scope>
</dependency>
+
+ <!-- Netty dependency is fixed to 4.1 here as Arrow
expects this. It should be removed or updated once Apache Arrow version is
upgraded. -->
Review Comment:
Can we also include the current Arrow version here so it will be more
obvious in the future which Arrow version was the cause for this without
browsing mvnrepo and its dependency matrix? :)
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -186,6 +186,8 @@ under the License.
<!-- Only parts of NOTICE file actually apply to the netty JAR and have been
manually
copied into this modules's NOTICE file. -->
<exclude>META-INF/NOTICE.txt</exclude>
+
<!-- Only .class files from flink-shaded-netty should be loaded, so don't
package any to flink-rpc-akka jar. -->
+
<exclude>**/*.class</exclude>
Review Comment:
Was this wrong before, or is it something new to handle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
