mateczagany commented on code in PR #27469:
URL: https://github.com/apache/flink/pull/27469#discussion_r2740089741
##########
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java:
##########
@@ -93,11 +94,11 @@ class ClientTest {
private static final Logger LOG =
LoggerFactory.getLogger(ClientTest.class);
// Thread pool for client bootstrap (shared between tests)
- private NioEventLoopGroup nioGroup;
+ private MultiThreadIoEventLoopGroup nioGroup;
Review Comment:
No, this will result in the exact same LoopGroup implementation, just
constructed with a new API:
https://github.com/netty/netty/wiki/Netty-4.2-Migration-Guide#new-best-practices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
