rionmonster opened a new pull request, #27486: URL: https://github.com/apache/flink/pull/27486
## What is the purpose of the change This pull request addresses the issue detailed in [FLINK-37351](https://issues.apache.org/jira/browse/FLINK-38783) which aims to ensure writer/committer colocation, specifically for non-pre-commit topologies, which should improve overall performance. ## Brief change log - Added a process within the existing `SinkTransformationTranslator.addCommittingTopology()` function to detect non-pre-commit topologies and define a colocation-group key for the transformation (via `setCoLocationGroupKey(...)`). ## Verifying this change This change added a series of tests in `SinkV2TransformationTranslatorITCase` to verify that colocation wasn't being applied (via a red-green cycle) as well as two other tests to confirm colocation was working for expected cases: - `testWriterAndCommitterColocatedWithoutPreCommitTopology` to verify writer/committer colocation for non-pre-commit topologies - `testWriterAndCommitterNotColocatedWithPreCommitTopology` to verify pre-commit sinks are not colocated - `testUserSpecifiedCoLocationGroupIsRespected` to verify user-specified colocation groups are preserved ### Example Tests <img width="724" height="434" alt="image" src="https://github.com/user-attachments/assets/87e36fc4-5990-4033-961e-7872899669f5"; /> ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: **no/don't know** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
