davidradl commented on code in PR #27486:
URL: https://github.com/apache/flink/pull/27486#discussion_r2740732814
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java:
##########
@@ -259,6 +259,15 @@ private static boolean isWriter(Transformation<?> t) {
private <CommT, WriteResultT> void addCommittingTopology(
Sink<T> sink, DataStream<T> inputStream) {
+
+ // Default to co-location for sinks without pre-commit topology
ensuring
+ // writer and committer run on the same TaskManager.
+ if (!(sink instanceof SupportsPreCommitTopology)
+ && transformation.getCoLocationGroupKey() == null) {
+ transformation.setCoLocationGroupKey(
Review Comment:
Can we move this logic into the else at line 289 - which is already `(!(sink
instanceof SupportsPreCommitTopology)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
