snuyanzin commented on code in PR #27488:
URL: https://github.com/apache/flink/pull/27488#discussion_r2740317762
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java:
##########
@@ -816,13 +816,8 @@ private ResultFetcher
callAlterMaterializedTableChangeOperation(
if (RefreshMode.FULL == oldMaterializedTable.getRefreshMode()) {
// directly apply the alter operation
- AlterMaterializedTableChangeOperation
alterMaterializedTableChangeOperation =
- new AlterMaterializedTableChangeOperation(
- tableIdentifier,
- op.getTableChanges(),
- op.getCatalogMaterializedTable());
return operationExecutor.callExecutableOperation(
- handle, alterMaterializedTableChangeOperation);
Review Comment:
anyway here and in other places it is just a copy as
`AlterMaterializedTableChangeOperation` since
`AlterMaterializedTableAsQueryOperation#execute` fails with
`UnsupportedOperationException`
not sure why it is done like that initially. Do not change the logic, just
make code a bit more compact here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
