snuyanzin commented on code in PR #27488:
URL: https://github.com/apache/flink/pull/27488#discussion_r2740323259
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java:
##########
@@ -922,32 +906,9 @@ private ResultFetcher
callAlterMaterializedTableChangeOperation(
private AlterMaterializedTableChangeOperation
generateRollbackAlterMaterializedTableOperation(
CatalogMaterializedTable oldMaterializedTable,
AlterMaterializedTableChangeOperation op) {
- List<TableChange> tableChanges = op.getTableChanges();
- List<TableChange> rollbackChanges = new ArrayList<>();
-
- for (TableChange tableChange : tableChanges) {
- if (tableChange instanceof TableChange.AddColumn) {
- TableChange.AddColumn addColumn = (TableChange.AddColumn)
tableChange;
-
rollbackChanges.add(TableChange.dropColumn(addColumn.getColumn().getName()));
- } else if (tableChange instanceof
TableChange.ModifyRefreshHandler) {
- rollbackChanges.add(
- TableChange.modifyRefreshHandler(
-
oldMaterializedTable.getRefreshHandlerDescription().orElse(null),
-
oldMaterializedTable.getSerializedRefreshHandler()));
- } else if (tableChange instanceof
TableChange.ModifyDefinitionQuery) {
- rollbackChanges.add(
-
TableChange.modifyDefinitionQuery(oldMaterializedTable.getExpandedQuery()));
- } else {
- throw new ValidationException(
- String.format(
- "Failed to generate rollback changes for
materialized table '%s'. "
- + "Unsupported table change detected:
%s. ",
- op.getTableIdentifier(), tableChange));
- }
- }
Review Comment:
since now `AlterMaterializedTableChangeOperation` contains old table and a
list of changes, there is no need to generate new list of changes to calculate
rollbacked table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
