SteveStevenpoor opened a new pull request, #27498:
URL: https://github.com/apache/flink/pull/27498

   ## What is the purpose of the change
   
   This pull request fixes a bug in the `MultiJoin` operator that produced 
incorrect results when join conditions contained `OR` expressions and execution 
parallelism was greater than 1.
   
   
   ## Brief change log
   
     - *Now equality conditions are only extracted from conjunctions (`AND` 
expressions)*
     - *Join conditions containing `OR` are treated as part of `postJoinFilter` 
and no longer affect `commonJoinKey` extraction or hash distribution creation*
     - *MultiJoin test with `OR` in join condition is fixed*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *MultiJoinTest*. 
*MultiJoinRestoreTest* and *MultiJoinSemanticTests* can't catch this bug since 
they work with parallelism == 1. Dedicated tests for this fix are introduced in 
[this PR](https://github.com/apache/flink/pull/27415), and all of them pass.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to