gustavodemorais commented on code in PR #27498:
URL: https://github.com/apache/flink/pull/27498#discussion_r2764368189
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/MultiJoinUtil.java:
##########
@@ -71,9 +71,13 @@ private static void extractEqualityConditions(
final SqlKind kind = call.getOperator().getKind();
if (kind != SqlKind.EQUALS) {
- for (final RexNode operand : call.getOperands()) {
- extractEqualityConditions(
- operand, inputOffsets, inputFieldCounts,
joinAttributeMap);
+ // Only conjunctions (AND) can contain equality conditions that
are valid for multijoin.
+ // All other condition types are deferred to the postJoinFilter.
+ if (kind == SqlKind.AND) {
Review Comment:
Hey @SteveStevenpoor, I think we should be good but could you add a test to
cover the above just to check? If there are issues, we can create another
ticket for you to address it.
1 - One test where we have a condition with key = true/false
1 - One test with a nested object
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/MultiJoinUtil.java:
##########
@@ -71,9 +71,13 @@ private static void extractEqualityConditions(
final SqlKind kind = call.getOperator().getKind();
if (kind != SqlKind.EQUALS) {
Review Comment:
```suggestion
if (kind == SqlKind.AND) {
```
Hey, could we then simplify to this check?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/MultiJoinUtil.java:
##########
@@ -71,9 +71,13 @@ private static void extractEqualityConditions(
final SqlKind kind = call.getOperator().getKind();
if (kind != SqlKind.EQUALS) {
Review Comment:
```suggestion
if (kind == SqlKind.AND) {
```
Hey, could we then simplify to this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
