Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96585254
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSetSingleRowJoin(
rowRelDataType: RelDataType,
joinCondition: RexNode,
joinRowType: RelDataType,
+ joinType: JoinRelType,
--- End diff --
Good point, but maybe add additional check in other method? for example in
`translateToPlan`.
In this case if ``DataSetSingleRowJoin.computeSelfCost`` don't return best
cost we don't get exception and don't select incorrect ``RelNode``. but if we
whatever get best cost we can throw exception in `translateToPlan` for
incorrect joinType.
What do you mean about it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
