Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96586208
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -46,6 +47,7 @@ class DataSetSingleRowJoin(
rowRelDataType: RelDataType,
joinCondition: RexNode,
joinRowType: RelDataType,
+ joinType: JoinRelType,
--- End diff --
That's a good point. I think we have not been very consistent in the past
when adding such checks in the `DataSetRelNodes`. I think the constructor would
be the right place though, because there is definitely something wrong with the
optimization process if the optimizer wants to consider a plan with an invalid
operator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
