ldadima commented on code in PR #27508:
URL: https://github.com/apache/flink/pull/27508#discussion_r2787387485


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/JoinITCase.scala:
##########
@@ -623,6 +624,22 @@ class JoinITCase(miniBatch: MiniBatchMode, state: 
StateBackendMode, enableAsyncS
     assertThat(sink.getRetractResults.sorted).isEqualTo(expected.sorted)
   }
 
+  @TestTemplate
+  def testInnerMultiJoinWithEqualPk(): Unit = {

Review Comment:
   Hi @gustavodemorais, You're right, but this 'MultiJoinRestoreTest uses 
RocksdbStateBackend 
([here](https://github.com/apache/flink/blob/338b7343ec11a6843c015acd0e1163d317c39079/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java#L289)),
 and to reproduce the issue, HeapStateBackend is needed.
   I think MultiJoinITCase is  more convinient. Also possible to add heap case 
for MultiJoinRestoreTest
   What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to