ddebowczyk92 commented on PR #27558: URL: https://github.com/apache/flink/pull/27558#issuecomment-3877736681
> @ddebowczyk92 > > Thanks for the contribution! > > We’ll likely want to introduce a unit test to verify this enum behavior, similar to some of the other conversion-based tests in `AvroRowDataDeSerializationSchemaTest.java`. There doesn’t appear to be any existing previous coverage there for enums, so adding one would make it easy to verify this behavior and help guard against future enum-related regressions. Hey @rionmonster, thanks for looking in. Since `AvroRowDataDeSerializationSchemaTest` tests the flow where the schema is derived from the `RowType` merely, and the case of conversion from VARCHAR to ENUM won't happen since ENUMs are not covered in Flink's type system, I decided to create a separate test class `AvroRowDataSchemaProvidedSerDeSchemaTest` that covers the flow of having a predefined schema, which is the case for the `avro-confluent` format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
