featzhang commented on code in PR #27544:
URL: https://github.com/apache/flink/pull/27544#discussion_r2796645437


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/AccessExecutionGraph.java:
##########
@@ -226,4 +226,14 @@ public interface AccessExecutionGraph extends 
JobStatusProvider {
      * @return ID of the application this job belongs to.
      */
     Optional<ApplicationID> getApplicationId();
+
+    /**
+     * Returns the scheduler of the current execution graph.
+     *
+     * @return The scheduler of the current execution graph.
+     */
+    @Nullable
+    default String getScheduler() {

Review Comment:
   The default implementation returns null, which introduces 
ambiguity,recommended:
   
   1. Document clearly what null represents.
   2. Or change return type to Optional<String>.
   3. Or remove default implementation to enforce explicit implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to