featzhang commented on code in PR #27544:
URL: https://github.com/apache/flink/pull/27544#discussion_r2796724760
##########
docs/static/generated/rest_v1_dispatcher.yml:
##########
@@ -2341,6 +2345,8 @@ components:
$ref: '#/components/schemas/JobID'
job-type:
$ref: '#/components/schemas/JobType'
+ scheduler:
+ type: string
Review Comment:
scheduler:
type: string
description: The scheduler implementation used by the job.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java:
##########
@@ -257,6 +257,8 @@ public class DefaultExecutionGraph implements
ExecutionGraph, InternalExecutionG
private VertexParallelismStore parallelismStore;
+ @Nullable private String scheduler;
Review Comment:
Use `String` for scheduler type is weakly, hard to validate.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/JobDetails.java:
##########
@@ -67,6 +73,9 @@ public class JobDetails implements Serializable {
private final String jobName;
+ @Nullable private final JobType jobType;
+ @Nullable private final String scheduler;
Review Comment:
Need Ensure:
equals()/hashCode() include scheduler ?
JSON serialization handles null properly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
